Conversation
|
Could you have a look at the CI tests - can you access them? https://flowcrypt.semaphoreci.com/workflows/90cb5578-60f3-4714-ba4f-11a037d5eae9?pipeline_id=72763e1f-a583-4292-a1e3-01f84c9f4302 |
|
@tomholub no, I get 404 error there |
|
Try again now - sent invite (you may need to log in with GitHub) |
|
Yes, now I can see them, checking, thanks! |
Semaphore has a command for this, something like |
|
Yes, I checked Semaphore documentation - for macOS images they have only ruby 2.3.7 and 2.5.1 preinstalled (https://docs.semaphoreci.com/ci-cd-environment/macos-xcode-11-image/#ruby), so I changed ruby version back to 2.5.1 and installed previous Cocoapods version which supports ruby 2.5 |
This PR includes:
mailcore2library (Cocoapods version doesn't work on M1 Macs)swiftformatis used from embedded pod (instead of system one). This change is recommended inswiftformatrepository - https://github.com/nicklockwood/SwiftFormat#alternative-locally-installed-swiftformat, as previous config could lead to inconsistencies in formatting for different team members (initiallyswiftformatfailed to run for me, possibly because I'm using zsh instead of bash and Xcode failed to find systemswiftformat)close #529
close #285 // edited tom - this also fixed this issue
close #302 // edited tom - also this
Tests:
flowcrypt-ios/FlowCryptUITests/test-ci-secrets.jsonfileTo be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):