issue #609 TypeScript-Core functionality to verify signatures#625
issue #609 TypeScript-Core functionality to verify signatures#625
Conversation
tomholub
left a comment
There was a problem hiding this comment.
checkpoint review, good
|
So I think I've finished with changes in the code, now just need to test it all. |
|
@tomholub Typescript tests passed but Swift tests failed here. |
|
Trying to rerun... |
|
@tomholub Finally, ready for review, I think. |
tomholub
left a comment
There was a problem hiding this comment.
Looks great - see comments
|
@tomholub Fixed above notes. Swift test still failing. |
tomholub
left a comment
There was a problem hiding this comment.
This looks good. Thanks! Since this only updates TS and TS tests pass, I'll force-merge this.
Actually no - it could still affect the app. I'll set auto-merge, once it's updated from master in a way that passes tests, it should merge. |
This PR refactors Typescript part in order to prepare to signature verification functionality.
close #609
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):