Merged
Conversation
tomholub
approved these changes
Oct 8, 2021
| platformName: 'iOS', | ||
| iosInstallPause: 5000, | ||
| deviceName: 'iPhone 11 Pro Max', | ||
| platformVersion: '14.5', |
Collaborator
There was a problem hiding this comment.
Would this run iOS 15 as well? We've just bumped app minimum ios requirement to 15.
Contributor
Author
There was a problem hiding this comment.
yeah, all we need is to replace platform version or even use ENV variable for that and run what you need, I will add ENV variable for this
|
|
||
| - iOS/Android Native Apps | ||
|
|
||
| ## Before running tests, please create a `./apps` directory, download the app and move the app file into that directory |
Collaborator
There was a problem hiding this comment.
Could there be a command to automate this? Maybe using fastlane? To create a build and immediately test it (it will be needed for CI anyway)
Contributor
Author
There was a problem hiding this comment.
yeah, we could make comand to copy .app file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introducec PR tests using appium.
close #469 // if this PR closes an issue
Tests
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):