Feature/issue 553 multiple recipient keys#676
Merged
Conversation
# Conflicts: # FlowCrypt.xcworkspace/xcshareddata/swiftpm/Package.resolved
tomholub
reviewed
Oct 14, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Early feedback - didn't have a chance to review all yet
FlowCrypt/Controllers/Settings/Contacts/Contacts List/ContactKeyDetailViewController.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Functionality/Services/Compose Message Service/ComposeMessageService.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Functionality/Services/Compose Message Service/ComposeMessageService.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Functionality/Services/Contacts Services/LocalContactsProvider.swift
Show resolved
Hide resolved
FlowCrypt/Functionality/Services/Contacts Services/LocalContactsProvider.swift
Outdated
Show resolved
Hide resolved
tomholub
reviewed
Oct 14, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Looking good! Some more / updated comments.
FlowCrypt/Functionality/Services/Contacts Services/Models/ContactKey.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Functionality/Services/Contacts Services/Models/ContactKey.swift
Outdated
Show resolved
Hide resolved
# Conflicts: # FlowCrypt.xcworkspace/xcshareddata/swiftpm/Package.resolved # Podfile.lock
tomholub
reviewed
Oct 15, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Very good. Please see comments. Haven't tried to run it yet.
Please also see if you are able to run the Appium tests after a change like this. I'll send you the env file. Thanks!
Collaborator
|
@fcvakintos please send me and also |
Collaborator
|
Did manual testing, looks good - I'll merge it first, please address the PR comments in a follow-up PR. |
tomholub
approved these changes
Oct 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes scheme to store multiple public keys per contacts.
UI also updated to show all available contact public keys + new screen added for contact key details.
close #553
close #337
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):