issue #554 add pub keys refresh for contacts#710
Conversation
|
@tomholub should we start adding tests for Realm models and services to improve test coverage? |
tomholub
left a comment
There was a problem hiding this comment.
I've removed a few private methods to make it clearer. Looks good, will test.
I'm not too worried about testing individual components - except when they do something complicated (what our db does is pretty simple). I would rather test larger functionality, to make sure it delivers business value. For example, to test that public keys indeed stay up to date. That's a harder test to write, but more valuable. We'll need a bunch of infrastructure for testing that, that I'll bring over from the browser extension. |
|
Works well. I tested the following scenario:
We'll write a UI test for this later. For the UI test to be viable, the WKD has to be mocked. |
This PR adds autorefresh for local pub keys.
close #554
Tests (delete all except exactly one):
LocalContactsProvideruses Realm, we're currently don't have setup for testing Realm modelsTo be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):