issues 739 735 772 run all appium tests, fix changing login lang

[fcvakintos]

#739 - run all tests
#735 - rename method
#772 - failed to change language during login

[tomholub]

Why is it that tests that restart app don't work - is there something we can do?

[fcvakintos]

@tomholub I need to investigate more... strange thing

[fcvakintos]

@tomholub bundle is changed?

[tomholub]

If you mean dependencies, sure - we update them when new versions come.

[tomholub]

I think retrying tests once when they fail is good, I would not be disabling that retry setting. But we should still investigate individual retries and improve them.

[fcvakintos]

If you mean dependencies, sure - we update them when new versions come.

I see bundle id with the new version is com.flowcrypt.as.ios.consumer

[tomholub]

If you mean dependencies, sure - we update them when new versions come.

I see bundle id with the new version is com.flowcrypt.as.ios.consumer

I see what you mean now. Yes, that was me, but this change was not intentional for CI tests. CI tests are running the Debug FlowCrypt scheme which has a com.flowcrypt.as.ios.debug bundle id - that's the one it's supposed to be using.

[fcvakintos]

com.flowcrypt.as.ios.debug

please add to env file on semaphoreci
BUNDLE_ID=com.flowcrypt.as.ios.debug

[fcvakintos]

@tomholub let me know when env file updated so I will push all fixes

[tomholub]

Interestingly, when I have a look at CI (the regular Swift tests) I see:

 21:03
| prelaunch_simulator                            | 1                                                                                           | 21:03
| reinstall_app                                  | false                                                                                       | 21:03
| app_identifier                                 | com.flowcrypt.ios.testflight                                                                | 21:03
| clean                                          | false                                                                                       | 21:03
| open_report                                    | false                        

That would explain why we had to build twice. But now I'm not entirely sure which bundle id is it running for appium. I'll take a closer look.

[tomholub]

I've merged master - npm commands were renamed

[tomholub]

instead of ios. it's now only.test. to make it clear it's not building the app, unlike just test which builds it too (npm convention)

[fcvakintos]

@tomholub did you update ENV file to include bundle id for tests?

BUNDLE_ID=com.flowcrypt.as.ios.debug

add this to env file on semaphore ci

[fcvakintos]

or can I upload myself?

[fcvakintos]

done

[tomholub]

@tomholub did you update ENV file to include bundle id for tests?

BUNDLE_ID=com.flowcrypt.as.ios.debug

add this to env file on semaphore ci

Please wait a bit - I'm cleaning up configurations and bundles, it's a mess. Once done, I'll let you know. I want to make sure it's all orderly. May take an hour or two (before I push / check tests still work / merge it). Then I'll add the updated .env file.

[fcvakintos]

@tomholub pull latest changes, I have all green. But make sure you have correct bundle_id in env file

[tomholub]

On browser extension (puppeteer) I use methods like waitAndClick and waitAndType and waitAndRead and so on. Generally, for every element that you interact with, you have to wait until it's there (and anyway it doesn't hurt to make sure first) so I recommend to use such methods (nearly) everywhere.

[fcvakintos]

yeah, let's make separate task for this to add ActionHelper file

[tomholub]

Approve if it can pass tests. But so far it's running into #769 a lot.

[fcvakintos]

@tomholub I added ENV file with specific bundle id but it could be another bundle id and tests will fail. Ah I uploaded wrong file

[tomholub]

I'll update the env file from here

[tomholub]

updated, re-running. Let's see. Locally they run well now.

[tomholub]

Thanks!

[fcvakintos]

@tomholub great progress so far =) job finished w/o any fails even w/o rerun