issue 738 build and scan swift tests one step#778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR speeds up build time of swift tests by no longer splitting into separate build and run steps, instead building and running in one go.
Also runs TypeScript + Swift tests in sequence on one machine since they are faster now (but still slower than Appium tests, so running both together doesn't waste time)
Makes sure Appium tests are defined first so if there is a shortage of available machines, the task that takes longer (appium) gets started first.
This shortened Swift build+test time from ~38m to ~17m.
close #738
Tests