Skip to content

issue 743 contacts.other search#844

Merged
tomholub merged 3 commits intomasterfrom
feature/issue-743-contacts-search
Nov 4, 2021
Merged

issue 743 contacts.other search#844
tomholub merged 3 commits intomasterfrom
feature/issue-743-contacts-search

Conversation

@sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented Oct 29, 2021

This PR adds search through email addresses which are not stored in user's Gmail contacts. It also needs additional auth scope https://www.googleapis.com/auth/contacts.other.readonly (currently it shows warning screen when user authenticates for the first time)

close #743


Tests (delete all except exactly one):

  • Difficult to test (explain why) - it needs Google auth for testing search results.

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky requested a review from tomholub October 29, 2021 12:33
@tomholub tomholub marked this pull request as draft October 29, 2021 12:51
@tomholub
Copy link
Collaborator

Thank you! I'll need to make it a draft, until Google approves the new scope.

@tomholub tomholub changed the title Feature/issue 743 contacts search [submit to Google] Feature/issue 743 contacts search Oct 29, 2021
@tomholub tomholub changed the title [submit to Google] Feature/issue 743 contacts search [submited to Google] Feature/issue 743 contacts search Nov 1, 2021
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works excellently. I've submitted the scope to google, now waiting to get approved.

@tomholub
Copy link
Collaborator

tomholub commented Nov 1, 2021

For us it usually takes about a week

image

@tomholub tomholub marked this pull request as ready for review November 3, 2021 19:41
@tomholub
Copy link
Collaborator

tomholub commented Nov 3, 2021

approved by google

@tomholub tomholub enabled auto-merge (squash) November 3, 2021 19:44
@tomholub tomholub changed the title [submited to Google] Feature/issue 743 contacts search issue 743 contacts.other search Nov 4, 2021
@tomholub tomholub merged commit 6904646 into master Nov 4, 2021
@tomholub tomholub deleted the feature/issue-743-contacts-search branch November 4, 2021 08:40
@sosnovsky sosnovsky mentioned this pull request Nov 21, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

contact search finds very few contacts compared to gmail

3 participants