Conversation
tomholub
left a comment
There was a problem hiding this comment.
Code looks good. Thanks! Will test.
|
|
||
| private func handleTap(at indexPath: IndexPath) { | ||
| guard let threadNode = node.nodeForRow(at: indexPath) as? TextImageNode else { | ||
| private func handleExpandTap(at indexPath: IndexPath) { |
There was a problem hiding this comment.
This name is much better - thank you!
tomholub
left a comment
There was a problem hiding this comment.
Works well. Maybe we should move the reply icon a tiny bit further from the chevron icon? Seem like they are a bit too close together. For spacing, can follow the space between the header icons which are comfortably apart. (people with fat fingers etc)
Agree, looks quite close. I was also thinking about removing |
This PR adds reply button to thread view and fixes expand/close button color.
close #936
close #940
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):