Skip to content

insertfix-mixin migration to XTerm 5 #70

@javier-godoy

Description

@javier-godoy

InsertFix does not work with XTerm 5.1.0. Reported the original issue upstream xtermjs/xterm.js#4359 in case it can be fixed there, so that we can get rid of the fix hack altogether.

Uncaught TypeError: Cannot read properties of undefined (reading 'markDirty')
    at InsertFixAddon.printHandler (xterm-insertfix-mixin.ts:72:36)
    at c.newPrintHandler [as _printHandler] (xterm-insertfix-mixin.ts:31:83)
    at c.parse (EscapeSequenceParser.ts:632:20)
    at E.parse (InputHandler.ts:485:35)
    at n._action (CoreTerminal.ts:145:99)
    at n._innerWrite (WriteBuffer.ts:164:27)
    at n.write (WriteBuffer.ts:120:14)
    at I.write (CoreTerminal.ts:155:23)
    at e2.Terminal.write (Terminal.ts:217:16)
    at xterm-element.ts:164:14
    at t2.EventEmitter.fire (EventEmitter.ts:55:16)
    at EventEmitter.ts:68:23
    at t2.EventEmitter.fire (EventEmitter.ts:55:16)
    at d.triggerDataEvent (CoreService.ts:77:18)
    at I._keyDown (Terminal.ts:1065:22)
    at HTMLTextAreaElement.<anonymous> (Terminal.ts:392:99)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions