-
Notifications
You must be signed in to change notification settings - Fork 6
Closed
Description
InsertFix does not work with XTerm 5.1.0. Reported the original issue upstream xtermjs/xterm.js#4359 in case it can be fixed there, so that we can get rid of the fix hack altogether.
XTermConsoleAddon/src/main/resources/META-INF/frontend/fc-xterm/xterm-insertfix-mixin.ts
Line 72 in 772d562
| inputHandler._dirtyRowService.markDirty(y); |
Uncaught TypeError: Cannot read properties of undefined (reading 'markDirty')
at InsertFixAddon.printHandler (xterm-insertfix-mixin.ts:72:36)
at c.newPrintHandler [as _printHandler] (xterm-insertfix-mixin.ts:31:83)
at c.parse (EscapeSequenceParser.ts:632:20)
at E.parse (InputHandler.ts:485:35)
at n._action (CoreTerminal.ts:145:99)
at n._innerWrite (WriteBuffer.ts:164:27)
at n.write (WriteBuffer.ts:120:14)
at I.write (CoreTerminal.ts:155:23)
at e2.Terminal.write (Terminal.ts:217:16)
at xterm-element.ts:164:14
at t2.EventEmitter.fire (EventEmitter.ts:55:16)
at EventEmitter.ts:68:23
at t2.EventEmitter.fire (EventEmitter.ts:55:16)
at d.triggerDataEvent (CoreService.ts:77:18)
at I._keyDown (Terminal.ts:1065:22)
at HTMLTextAreaElement.<anonymous> (Terminal.ts:392:99)
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done