feat: add new-jamneration team#8
Conversation
- Add workflow file for new-jamneration performance tests - Add badge row to README.md - Create teams/new-jamneration/ directory - Add workflow trigger to deploy-dashboard.yml Docker image: ghcr.io/new-jamneration/new-jamneration-target:latest Source: https://github.com/New-JAMneration/JAM-Protocol
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis pull request adds a new performance testing workflow for the "new-jamneration" target, including the workflow definition that runs daily and can be triggered manually, integration with the deployment dashboard via workflow_run triggers, and documentation in the README. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can enable review details to help with troubleshooting, context usage and more.Enable the |
|
@YCC3741 seems the image is private or non-existent, can you check? |
|
Sure. I'll check it |
|
@tomusdrw |
|
@YCC3741 Seems to be running fine now, but the tests are failing, because we expect exit code 0, however your client returns exit code 2 for some reason. Note we do send SIGTERM to the process after the tests are finished - maybe that's related? Could you inspect that and let me know if you are able to return exit code 0 in such case? See logs here: https://github.com/FluffyLabs/jam-testing/actions/runs/23130924250/job/67183937459 |
|
I've fixed the issue mentioned. The client now handles SIGTERM properly and returns exit code 0 when the tests finish. |
|
Hi @tomusdrw, we've updated our Docker image with graceful SIGTERM handling (exit code 0). The performance workflow is already passing. Could you re-run this fuzz workflow? Thanks! |

Summary
new-jamnerationteam to the JAM testing suiteghcr.io/new-jamneration/new-jamneration-target:latestChanges
.github/workflows/new-jamneration-performance.yml— team workflow fileREADME.md— add badge rowteams/new-jamneration/— team directory.github/workflows/deploy-dashboard.yml— add workflow triggerChecklist
README.mdteams/new-jamneration/directory created"Performance: new-jamneration"deploy-dashboard.ymlupdated with workflow triggerSummary by CodeRabbit