Skip to content

feat: add new-jamneration team#8

Merged
tomusdrw merged 1 commit intoFluffyLabs:mainfrom
YCC3741:add-new-jamneration
Mar 15, 2026
Merged

feat: add new-jamneration team#8
tomusdrw merged 1 commit intoFluffyLabs:mainfrom
YCC3741:add-new-jamneration

Conversation

@YCC3741
Copy link
Copy Markdown
Contributor

@YCC3741 YCC3741 commented Mar 15, 2026

Summary

Changes

  • .github/workflows/new-jamneration-performance.yml — team workflow file
  • README.md — add badge row
  • teams/new-jamneration/ — team directory
  • .github/workflows/deploy-dashboard.yml — add workflow trigger

Checklist

  • Workflow file follows the pattern of existing ones
  • Badge row added to README.md
  • teams/new-jamneration/ directory created
  • Workflow name matches "Performance: new-jamneration"
  • deploy-dashboard.yml updated with workflow trigger
  • Docker image is publicly pullable
  • Source repo is public
  • No changes to shared infrastructure

Summary by CodeRabbit

  • Chores
    • Established a new automated performance testing workflow that executes daily at 06:00 UTC with support for manual on-demand triggering
    • Integrated the performance testing workflow into the continuous deployment pipeline to automatically run upon completion of other workflows
    • Updated project documentation to reflect the new performance testing feature

- Add workflow file for new-jamneration performance tests
- Add badge row to README.md
- Create teams/new-jamneration/ directory
- Add workflow trigger to deploy-dashboard.yml

Docker image: ghcr.io/new-jamneration/new-jamneration-target:latest
Source: https://github.com/New-JAMneration/JAM-Protocol
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d0115c30-b604-4c12-90ca-c27b198c1cda

📥 Commits

Reviewing files that changed from the base of the PR and between ca4f3f4 and 25501f8.

📒 Files selected for processing (4)
  • .github/workflows/deploy-dashboard.yml
  • .github/workflows/new-jamneration-performance.yml
  • README.md
  • teams/new-jamneration/.gitkeep

📝 Walkthrough

Walkthrough

This pull request adds a new performance testing workflow for the "new-jamneration" target, including the workflow definition that runs daily and can be triggered manually, integration with the deployment dashboard via workflow_run triggers, and documentation in the README.

Changes

Cohort / File(s) Summary
GitHub Workflows
​.github/workflows/deploy-dashboard.yml, ​.github/workflows/new-jamneration-performance.yml
Adds "Performance: new-jamneration" to workflow_run triggers in deploy-dashboard.yml and creates a new scheduled performance testing workflow that reuses the picofuzz template with new-jamneration-specific configuration.
Documentation
README.md
Adds new-jamneration entry to the Performance table with its associated badge and link.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 A new target hops into the race,
Daily performance tests to check its pace,
Jamneration swift with metrics so fine,
The dashboard now watches this fuzzy line! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding a new team (new-jamneration) to the testing suite, which is the primary objective reflected in the workflow files, README updates, and directory structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can enable review details to help with troubleshooting, context usage and more.

Enable the reviews.review_details setting to include review details such as the model used, the time taken for each step and more in the review comments.

@tomusdrw tomusdrw merged commit ad8d4e7 into FluffyLabs:main Mar 15, 2026
1 check passed
@tomusdrw
Copy link
Copy Markdown
Member

@YCC3741 seems the image is private or non-existent, can you check?

@YCC3741
Copy link
Copy Markdown
Contributor Author

YCC3741 commented Mar 15, 2026

Sure. I'll check it

@YCC3741
Copy link
Copy Markdown
Contributor Author

YCC3741 commented Mar 15, 2026

image Done. Thanks a lot.

@YCC3741
Copy link
Copy Markdown
Contributor Author

YCC3741 commented Mar 15, 2026

@tomusdrw
Hi, the previous run of new-jamneration-performance.yml failed because our Docker image (ghcr.io/new-jamneration/new-jamneration-target) was set to private. We've updated the visibility to public now. Could you please re-run the workflow? Thank you!

@tomusdrw
Copy link
Copy Markdown
Member

@YCC3741 Seems to be running fine now, but the tests are failing, because we expect exit code 0, however your client returns exit code 2 for some reason. Note we do send SIGTERM to the process after the tests are finished - maybe that's related? Could you inspect that and let me know if you are able to return exit code 0 in such case? See logs here: https://github.com/FluffyLabs/jam-testing/actions/runs/23130924250/job/67183937459

@YCC3741
Copy link
Copy Markdown
Contributor Author

YCC3741 commented Mar 16, 2026

I've fixed the issue mentioned. The client now handles SIGTERM properly and returns exit code 0 when the tests finish.

@YCC3741
Copy link
Copy Markdown
Contributor Author

YCC3741 commented Mar 17, 2026

Hi @tomusdrw, we've updated our Docker image with graceful SIGTERM handling (exit code 0). The performance workflow is already passing. Could you re-run this fuzz workflow? Thanks!

@tomusdrw
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants