fix(ci): pass --features to cargo via -- separator in wasm-pack#27
Merged
Alex-Wengg merged 1 commit intomainfrom Apr 27, 2026
Merged
fix(ci): pass --features to cargo via -- separator in wasm-pack#27Alex-Wengg merged 1 commit intomainfrom
Alex-Wengg merged 1 commit intomainfrom
Conversation
wasm-pack build does not accept --features directly. Cargo arguments must come after the -- separator. This was breaking the WASM CI job with: error: Found argument '--features' which wasn't expected.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
error: Found argument '--features' which wasn't expected, or isn't valid in this contextwasm-pack builddoes not accept--featuresdirectly; cargo arguments must come after the--separatorContext
Failing job: https://github.com/FluidInference/text-processing-rs/actions/runs/24977493447/job/73132168878
Before:
After:
Test plan
npm run wasm:build:nodesucceeds locallynpm run wasm:build:websucceeds locallynpm run wasm:cisucceeds locally