ABI change without SONAME bump

[derselbst]

FluidSynth 1.1.4 breaks the binary compatibility with the previous releases as it dropped one public symbol:

dpkg-gensymbols: warning: debian/libfluidsynth1/DEBIAN/symbols doesn't match completely debian/libfluidsynth1.symbols
--- debian/libfluidsynth1.symbols (libfluidsynth1_1.1.4-1_amd64)
+++ dpkg-gensymbolsWTLLjv 2011-08-05 07:51:13.943270426 +0000
@@ -89,6 +89,7 @@

fluid_adsr_env_set_data@Base 1.1.3
fluid_allpass_getfeedback@Base 1.1.3
fluid_allpass_init@Base 1.1.3

+ fluid_allpass_release@Base 1.1.4-1

fluid_allpass_setbuffer@Base 1.1.3
fluid_allpass_setfeedback@Base 1.1.3
fluid_alsa_audio_driver_settings@Base 1.1.3

@@ -121,6 +122,7 @@

fluid_comb_getdamp@Base 1.1.3
fluid_comb_getfeedback@Base 1.1.3
fluid_comb_init@Base 1.1.3

+ fluid_comb_release@Base 1.1.4-1

fluid_comb_setbuffer@Base 1.1.3
fluid_comb_setdamp@Base 1.1.3
fluid_comb_setfeedback@Base 1.1.3

@@ -157,7 +159,7 @@

fluid_defsfont_add_sample@Base 1.1.3
fluid_defsfont_get_name@Base 1.1.3
fluid_defsfont_get_preset@Base 1.1.3

- fluid_defsfont_get_sample@Base 1.1.3
+#MISSING: 1.1.4-1# fluid_defsfont_get_sample@Base 1.1.3

fluid_defsfont_iteration_next@Base 1.1.3
fluid_defsfont_iteration_start@Base 1.1.3
fluid_defsfont_load@Base 1.1.3

This means an ABI-change but no SONAME bump has happen'd, could you please fix that?

Reported by: quadrispro

Original Ticket: fluidsynth/tickets/98

[derselbst]

I admit not knowing much about this, so excuse me if this is a dumb question, but... could you explain it a little, especially considering that fluid_defsfont_get_sample is not part of the public API? So any external program using this function is broken in itself, if it breaks from this symbol being removed.
(The reason it's not declared static, and thus present in the first place, is because it is used between different source code files, not between libraries.)

Original comment by: diwic

[derselbst]

• attachment _libfluidsynth1.symbols.1.1.3_ added

Original comment by: quadrispro

[derselbst]

• attachment _libfluidsynth1.symbols.1.1.4_ added

Original comment by: quadrispro

[derselbst]

David,

please have a look at the symbols exported by the 1.1.3's library (dpkg-gensynmbols(1)), I cannot assume there's no external application using that call.

So, please, bump the SONAME.

Original comment by: quadrispro

[derselbst]

• status changed from new to closed
• resolution set to fixed

Fixed in r428 by reinserting the function, as recommended by plcl here: https://lists.nongnu.org/archive/html/fluid-dev/2011-08/msg00027.html

Original comment by: diwic

[derselbst]

Thanks!

Original comment by: quadrispro