fix(security): harden dashboard api surface (sec-api-01..11)#42
Open
Abdulkhalek-1 wants to merge 2 commits intomainfrom
Open
fix(security): harden dashboard api surface (sec-api-01..11)#42Abdulkhalek-1 wants to merge 2 commits intomainfrom
Abdulkhalek-1 wants to merge 2 commits intomainfrom
Conversation
Implements 11 security hardening plans for the dashboard REST API: - sec-api-01: block self-grant and wildcard permission escalation - sec-api-02: restrict audit log userId filter to self for non-owners - sec-api-03: validate audit log date range query parameters - sec-api-04: add per-user rate limits to music/commands/giveaways creation - sec-api-05: magic-byte validation for welcome background image uploads - sec-api-06: rate limit + 250ms budget on cron preview endpoint - sec-api-07: reject unsafe regex (ReDoS) in custom command creation - sec-api-08: drop permission key from 403 error responses - sec-api-09: exact-match allowlist for audit action filter - sec-api-10: add X-Content-Type-Options nosniff to image preview - sec-api-11: distinguish Prisma P2025 from 500s in actions rule update Adds safe-regex dependency. Includes 49 new tests across 9 files covering each hardening. Typecheck clean; no new regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements 11 security hardening plans for the dashboard REST API.
Changes
Test plan
🤖 Generated with Claude Code