Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Base.Setand possibly other AbstractSets are treated as normalstructs. Since
Base.Set{K}wraps aDict{K,Nothing}, the Set constructortreats its input as an iterable of values, and
DictiteratesPairs,Setsend up as
Set{Pair{T,Nothing}}after walking.This adds tests to ensure that
SetandOrderedSet(on behalf of allAbstractSets everywhere) survivefmap.I'm not 100% sure this is the right way to handle these (generally) un-ordered,
not-natively-
mapable collections (I think you might get surprising resultsusing
fmapwith multiple arguments for instance. I can work aroudn this withsome lite type piracy but wanted to open this up for discussion anyway!