Fail on defects #125
Merged
Fail on defects #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swarkentin
approved these changes
Jul 11, 2023
Contributor
|
LGTM - oh. Is already merged. Well, regardless, LGTM :p |
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes MH-13761
Slack: https://forallsecure.slack.com/archives/C04S0TJ6TQC/p1681758129405209
Uses new
--fail-on-defectsflag in CLI to fail workflow in the presence of defects. Only works on >= 2.5.There are some additional ideas about improving sarif output here, but enabling this flag to get back to gating run behavior is contained here.
Example run at https://github.com/mjkoo/mcode-action-examples/actions/runs/5511956665