Skip to content

YOLO-5487: Commercial api outgoings recovery#41

Merged
nzjohan merged 8 commits into
feature/YOLO-5053-commercial-apifrom
feature/YOLO-5487-commercial-api-outgoings-recovery
Sep 25, 2025
Merged

YOLO-5487: Commercial api outgoings recovery#41
nzjohan merged 8 commits into
feature/YOLO-5053-commercial-apifrom
feature/YOLO-5487-commercial-api-outgoings-recovery

Conversation

@nzjohan
Copy link
Copy Markdown
Contributor

@nzjohan nzjohan commented Sep 23, 2025

Overview

Extending API functionality to Outgoings recoveries and recoveryProfiles:

"outgoings": {
        "outgoingsDate": "2025-09-10T04:55:38.700Z",
        "items": [{
                "name": "Municipal/Council Rates Testing",
                "type": "Statutory Expenses Testing",
                "pcaCategory": "testing",
                "isRecoverable": true,
                "growthRateName": "testing",
                "previousBudget": 0,
                "currentBudget": 0,
                "adoptedBudget": 0,
                "recoveries": [{
                        "code": "CODE1",
                        "allocationPercentage": 0.1,
                        "adjustmentAmount": 1,
                        "adoptedArea": 111
                    }
                ]
            }
        ],
        "recoveryProfiles": [{
                "code": "CODE1",
                "description": "Base Profile",
                "adoptedArea": 1111,
                "firstAdjustmentAmount": 1111,
                "secondAdjustmentAmount": 1111
            }
        ]
    } 

@nzjohan nzjohan requested a review from Copilot September 24, 2025 01:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the commercial API to support outgoings recoveries and recovery profiles functionality. The changes introduce new data transfer objects (DTOs) for handling recovery profiles and outgoings recoveries within the commercial outgoings system.

  • Adds new DTOs for outgoings recovery and recovery profile data structures
  • Integrates recovery collections into existing outgoings items and main outgoings structure
  • Establishes the foundation for commercial property expense recovery tracking

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
RecoveryProfileDto.cs New DTO defining recovery profile structure with code, description, and area adjustments
OutgoingsRecoveryDto.cs New DTO for individual recovery entries with allocation percentages and amounts
OutgoingsItemDto.cs Enhanced to include recoveries collection and required imports
OutgoingsDto.cs Extended to include recovery profiles collection

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nzjohan nzjohan merged commit 432bdcf into feature/YOLO-5053-commercial-api Sep 25, 2025
@nzjohan nzjohan deleted the feature/YOLO-5487-commercial-api-outgoings-recovery branch September 25, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants