-
Notifications
You must be signed in to change notification settings - Fork 3
refactor(journey-client): rename frstep to journeystep and frcallback… #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… to journeycallback
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Comment |
|
View your CI Pipeline Execution ↗ for commit 9972488
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## create-journey-package #414 +/- ##
===========================================================
+ Coverage 18.04% 80.55% +62.50%
===========================================================
Files 138 44 -94
Lines 27318 3646 -23672
Branches 916 342 -574
===========================================================
- Hits 4930 2937 -1993
+ Misses 22388 709 -21679
🚀 New features to boost your workflow:
|
|
Deployed 616a209 to https://ForgeRock.github.io/ping-javascript-sdk/pr-414/616a209cfb4b205f3b8fb9c214b6498c33724618 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔺 @forgerock/sdk-utilities - 7.5 KB (+3.5 KB, +86.1%) 🆕 New Packages🆕 @forgerock/journey-client - 0.0 KB (new) ➖ No Changes➖ @forgerock/davinci-client - 34.2 KB 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
cerebrl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a huge fan of replacing FR with Journey, but I can't think of a better replacement. The only alternative would be to just remove FR and leave it with no prefix.
… to journeycallback
JIRA Ticket
see #412 for ticket
Description
Breaking out more work so its easier to digest in review.
Change FRStep prefix to JourneyStep as much as possible