Skip to content

Conversation

@ryanbas21
Copy link
Collaborator

… to journeycallback

JIRA Ticket

see #412 for ticket

Description

Breaking out more work so its easier to digest in review.

Change FRStep prefix to JourneyStep as much as possible

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2025

⚠️ No Changeset found

Latest commit: 9972488

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Sep 18, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rename-fr-step

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Sep 18, 2025

View your CI Pipeline Execution ↗ for commit 9972488

Command Status Duration Result
nx run-many -t build ✅ Succeeded 5s View ↗
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 13s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-18 20:06:13 UTC

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 97.72727% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.55%. Comparing base (703e47f) to head (9972488).

Files with missing lines Patch % Lines
...ckages/journey-client/src/lib/fr-webauthn/index.ts 77.77% 2 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           create-journey-package     #414       +/-   ##
===========================================================
+ Coverage                   18.04%   80.55%   +62.50%     
===========================================================
  Files                         138       44       -94     
  Lines                       27318     3646    -23672     
  Branches                      916      342      -574     
===========================================================
- Hits                         4930     2937     -1993     
+ Misses                      22388      709    -21679     
Files with missing lines Coverage Δ
...ient/src/lib/callbacks/attribute-input-callback.ts 95.12% <100.00%> (ø)
...ourney-client/src/lib/callbacks/choice-callback.ts 100.00% <100.00%> (ø)
...-client/src/lib/callbacks/confirmation-callback.ts 100.00% <100.00%> (ø)
...lient/src/lib/callbacks/device-profile-callback.ts 100.00% <100.00%> (ø)
...ckages/journey-client/src/lib/callbacks/factory.ts 100.00% <100.00%> (ø)
...-client/src/lib/callbacks/hidden-value-callback.ts 100.00% <100.00%> (ø)
packages/journey-client/src/lib/callbacks/index.ts 90.29% <100.00%> (ø)
...ey-client/src/lib/callbacks/kba-create-callback.ts 93.54% <100.00%> (ø)
...rney-client/src/lib/callbacks/metadata-callback.ts 100.00% <100.00%> (ø)
.../journey-client/src/lib/callbacks/name-callback.ts 100.00% <100.00%> (ø)
... and 18 more

... and 94 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Deployed 616a209 to https://ForgeRock.github.io/ping-javascript-sdk/pr-414/616a209cfb4b205f3b8fb9c214b6498c33724618 branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions
Copy link
Contributor

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🚨 Significant Changes

🔺 @forgerock/sdk-utilities - 7.5 KB (+3.5 KB, +86.1%)
🔺 @forgerock/sdk-types - 8.0 KB (+2.1 KB, +35.3%)

🆕 New Packages

🆕 @forgerock/journey-client - 0.0 KB (new)
🆕 @forgerock/journey-client - 82.2 KB (new)

➖ No Changes

@forgerock/davinci-client - 34.2 KB
@forgerock/device-client - 9.2 KB
@forgerock/protect - 150.1 KB
@forgerock/sdk-oidc - 2.7 KB
@forgerock/sdk-logger - 1.6 KB
@forgerock/storage - 1.4 KB
@forgerock/sdk-request-middleware - 4.4 KB
@forgerock/iframe-manager - 2.4 KB
@forgerock/oidc-client - 23.1 KB


13 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

Copy link
Collaborator

@cerebrl cerebrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of replacing FR with Journey, but I can't think of a better replacement. The only alternative would be to just remove FR and leave it with no prefix.

@ryanbas21 ryanbas21 merged commit 236f0d4 into create-journey-package Sep 24, 2025
4 checks passed
@ryanbas21 ryanbas21 deleted the rename-fr-step branch September 24, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants