Skip to content
This repository was archived by the owner on Feb 19, 2022. It is now read-only.

Improve wording#15

Open
trusktr wants to merge 2 commits intoFormidableLabs:masterfrom
trusktr:patch-1
Open

Improve wording#15
trusktr wants to merge 2 commits intoFormidableLabs:masterfrom
trusktr:patch-1

Conversation

@trusktr
Copy link

@trusktr trusktr commented Feb 11, 2018

It was confusing.

@trusktr
Copy link
Author

trusktr commented Feb 11, 2018

And, to prove how confused I was, I fix my wrong wording. 🤣

* Replaces `package.json:dependencies` with
`ARCHETYPE-dev/package.json:dependencies`
* Replaces `package.json:dependencies` that were copied from root with
`ARCHTYPE-dev/package.json:dependencies`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: s/ARCHTYPE/ARCHETYPE/

for development tasks only.
* `dev/package.json`
* `../ARCHETYPE-dev/package.json`
for development tasks only. One of the following should exist:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, One, and only one, of the following ?

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping clarify! Just have one typo + one possible additional tweak and then I'll merge...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants