Skip to content

normalize link break#13

Open
bluelovers wants to merge 1 commit intoFormidableLabs:masterfrom
bluelovers:master
Open

normalize link break#13
bluelovers wants to merge 1 commit intoFormidableLabs:masterfrom
bluelovers:master

Conversation

@bluelovers
Copy link

No description provided.

@ryan-roemer
Copy link
Member

This tool renders just fine on windows (include cmd). Can you explain more why we need to add this dependency and further mutate output strings?

screen shot 2018-06-03 at 7 35 08 am

@bluelovers
Copy link
Author

because at windows sme ppl use lf , some ppl use crlf
when git clone

@ryan-roemer
Copy link
Member

Can you give me a publish-diff command for a repo that has that that doesn’t render correctly on windows or Mac so that I am see the problem myself? Thanks!

@bluelovers
Copy link
Author

2018-06-04-09-22-01-1

@ryan-roemer
Copy link
Member

ryan-roemer commented Jun 4, 2018

I can't read the command in the image you pasted you're issuing to actually see for yourself.

Can you type out a command for me to type myself to see what you're seeing?

And, also reproduction steps if I need to git clone a specific repo on a Windows machine or something... I tried random publish-diff's with benchmark trying to reverse engineer what you're typing but everything diffs fine on Mac and Windows.

@ryan-roemer
Copy link
Member

Also include what OS you're on and terminal you're using. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants