Skip to content

Conversation

@pietgk
Copy link
Contributor

@pietgk pietgk commented Jul 20, 2025

Description

Fixes issue that i had to start developing with this repo:

  • build not failing on mostly typescript issues
  • could not run the playground due to typescript, lint and swift warnings and errors.

needs review regarding:

  • the original code felt partly not finished so not sure on how to proceed. Would be nice to get feedback on this PR and the status of the current code.

  • not sure if logger.ts was commented out (but still referenced from other files) for deletion or for fixing later.

  • swift code did not compile so not sure how to see that.

  • fixed all issues to get build working again

  • 2 skipped tests still skipped

  • looking into why test are not passing in core

Type of Change

  • fixes ot typescript, swift, lint, build config level (non-breaking change which fixes issues)

How Has This Been Tested?

in the playground dir running yarn ios --device without getting any build or runtime errors
yarn build not does not give errors or warnings
linting and ts:check now pass

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Jul 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-ama ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2025 11:12am

@ceceppa
Copy link
Member

ceceppa commented Jul 21, 2025

Thanks for the PR.

the original code felt partly not finished so not sure on how to proceed. Would be nice to get feedback on this PR and the status of the current code.

That's correct, the code is not finished. So far, I've merged into main some code after working on a POC to test the feasibility of running the checker on the native side.
So, main branch will probably be broken for some time until the feature gets completed.
However, I'll be merging your PR. Thanks for the fixes :)

not sure if logger.ts was commented out (but still referenced from other files) for deletion or for fixing later.

When testing locally, I encountered issues importing that file. Additionally, now that checks have been completed on the native side, it will likely be moved. This, along with the "internal" package.

swift code did not compile so not sure how to see that.

Do you have a log of the error?

looking into why test are not passing in core

I won't be worrying too much about the test at the moment, as many things will be changing in the core.

@ceceppa ceceppa marked this pull request as ready for review July 21, 2025 10:52
@ceceppa ceceppa merged commit 15e5b72 into FormidableLabs:main Jul 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants