fixes to get AMA playground running. #325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue that i had to start developing with this repo:
needs review regarding:
the original code felt partly not finished so not sure on how to proceed. Would be nice to get feedback on this PR and the status of the current code.
not sure if logger.ts was commented out (but still referenced from other files) for deletion or for fixing later.
swift code did not compile so not sure how to see that.
fixed all issues to get build working again
2 skipped tests still skipped
looking into why test are not passing in core
Type of Change
How Has This Been Tested?
in the playground dir running yarn ios --device without getting any build or runtime errors
yarn build not does not give errors or warnings
linting and ts:check now pass
Checklist: (Feel free to delete this section upon completion)