Skip to content

Revert replaceing 'compile' with 'implementation' in android/build.gradle #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kadikraman merged 2 commits into from
Feb 18, 2019
Merged

Revert replaceing 'compile' with 'implementation' in android/build.gradle #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea0d4c4
Revert "Replace 'compile' with 'implementation' (#242)"
Feb 18, 2019
c409498
Add readme comment on patch package
Feb 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,8 @@ class AppDelegate: UIApplicationDelegate, RNAppAuthAuthorizationFlowManager {

### Android Setup

**Note:** for RN >= 0.57, you will get a warning about compile being obsolete. To get rid of this warning, use [patch-package](https://github.com/ds300/patch-package) to replace compile with implementation [as in this PR](https://github.com/FormidableLabs/react-native-app-auth/pull/242) - we're not deploying this right now, because it would break the build for RN < 57.

To setup the Android project, you need to perform two steps:

1. [Install Android support libraries](#install-android-support-libraries)
Expand Down
4 changes: 2 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ repositories {
}

dependencies {
implementation 'com.facebook.react:react-native:+'
implementation "net.openid:appauth:0.7.1"
compile 'com.facebook.react:react-native:+'
compile "net.openid:appauth:0.7.1"
}