Skip to content

fix: properly highlight search results with accents and diacritics#435

Merged
naveensingh merged 3 commits intoFossifyOrg:mainfrom
jguegel:highlights-12
Dec 14, 2025
Merged

fix: properly highlight search results with accents and diacritics#435
naveensingh merged 3 commits intoFossifyOrg:mainfrom
jguegel:highlights-12

Conversation

@jguegel
Copy link
Contributor

@jguegel jguegel commented Dec 12, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Fixed highlighting for Search with accents and diacritics

Tests performed

  • searched with letters without accents and diacritics -> result highlights contain accents and diacritics
ignoreImageMinify

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@jguegel jguegel requested a review from naveensingh as a code owner December 12, 2025 21:59
@jguegel
Copy link
Contributor Author

jguegel commented Dec 13, 2025

@naveensingh if you want i can have a look in the phone app too (problem exists there too, see also comment in #12) , i couldn't find an issue (bugticket). should i just create a ticket for it or would it be fine without?

@naveensingh
Copy link
Member

Sure

@jguegel
Copy link
Contributor Author

jguegel commented Dec 13, 2025

same same but different FossifyOrg/Phone#661

@naveensingh naveensingh changed the title Fixed highlighting for Search with accents and diacritics #12 fix: properly highlight search results with accents and diacritics Dec 13, 2025
@jguegel jguegel requested a review from naveensingh December 13, 2025 14:47
@naveensingh naveensingh merged commit 2274085 into FossifyOrg:main Dec 14, 2025
6 checks passed
@jguegel jguegel deleted the highlights-12 branch December 15, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Contacts + Dialer words with "á" arent highlighted

2 participants