Skip to content

fix: use activity context in keyboard language management dialog #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 1 commit into from
Aug 27, 2025
Merged

fix: use activity context in keyboard language management dialog #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Added
- German QWERTZ layout without dedicated umlaut keys ([#47])

### Changed
- Updated French AZERTY layout ([#134])
- Updated Spanish layout ([#206])

### Added
- German QWERTZ layout without dedicated umlaut keys ([#47])
### Fixed
- Keyboard language management dialog now respects `Use English language` preference ([#238])

## [1.4.0] - 2025-08-22
### Added
Expand Down Expand Up @@ -83,6 +86,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#202]: https://github.com/FossifyOrg/Keyboard/issues/202
[#222]: https://github.com/FossifyOrg/Keyboard/issues/222
[#230]: https://github.com/FossifyOrg/Keyboard/issues/230
[#238]: https://github.com/FossifyOrg/Keyboard/issues/238

[Unreleased]: https://github.com/FossifyOrg/Keyboard/compare/1.4.0...HEAD
[1.4.0]: https://github.com/FossifyOrg/Keyboard/compare/1.3.0...1.4.0
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/kotlin/org/fossify/keyboard/adapters/ManageKeyboardLanguagesAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ internal class ManageKeyboardLanguagesAdapter(
override fun onBindViewHolder(holder: MyViewHolder, position: Int) {
val item = languagesList[position]
holder.languageCheckboxItem.apply {
text = config.context.getKeyboardLanguageText(item)
text = context.getKeyboardLanguageText(item)
isChecked = selectedLanguages.contains(item)

setOnClickListener {
Expand All @@ -47,7 +47,7 @@ internal class ManageKeyboardLanguagesAdapter(

fun getSelectedLanguages(): MutableSet<Int> {
val defaultLang = config.getDefaultLanguage()
if (selectedLanguages.size == 0) {
if (selectedLanguages.isEmpty()) {
selectedLanguages.add(defaultLang)
}
return selectedLanguages
Expand Down
Loading