[#234] Added option to show (default) or not the emoji key in the settings menu.#319
Merged
naveensingh merged 4 commits intoFossifyOrg:mainfrom Nov 24, 2025
Merged
Conversation
…in the settings menu.
naveensingh
requested changes
Nov 11, 2025
Member
There was a problem hiding this comment.
It seems to work fine!
Instead of calling .adjustForEmojiButton() everywhere, it'll be cleaner to create a helper for constructing the keyboard:
private fun constructKeyboard(xmlLayoutResId: Int, enterKeyType: Int): MyKeyboard {
return MyKeyboard(
context = this,
xmlLayoutResId = xmlLayoutResId,
enterKeyType = enterKeyType
).adjustForEmojiButton()
}And then replace every MyKeyboard(*args).adjustForEmojiButton() occurrence with this function. More comments below:
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
…in the settings menu. Fix: Address reviewer feedback
naveensingh
requested changes
Nov 13, 2025
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/keyboard/services/SimpleKeyboardIME.kt
Outdated
Show resolved
Hide resolved
…in the settings menu. Fix: Address reviewer feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Tests performed
Before & after preview
The key simply appear / disappear I don't think an image is needed.
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).