Skip to content

fix: reset search state on page change #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
naveensingh merged 2 commits into from
Sep 8, 2025
Merged

fix: reset search state on page change #216

naveensingh merged 2 commits into from
Sep 8, 2025

Conversation

@naveensingh
Copy link
Member

@naveensingh naveensingh commented Sep 8, 2025 •
edited
Loading

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Reset search index and matches on page change.
  • Added a safeSetSelection() method to avoid any other index out of bounds crashes.

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • All checks are passing.

@naveensingh naveensingh changed the title fix: reset search on page change fix: reset search state on page change Sep 8, 2025
@naveensingh naveensingh merged commit 5691143 into main Sep 8, 2025
7 checks passed
@naveensingh naveensingh deleted the naveensingh/reset-search-on-page-change branch September 8, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crash while using the search field.

2 participants

@naveensingh