-
Notifications
You must be signed in to change notification settings - Fork 32
Translate responsive web design projects #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
S1ngS1ng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
| * Build a Personal Portfolio Webpage | ||
| * 搭建致敬页 | ||
| * 搭建调查表格 | ||
| * 搭建产品着陆页 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“着陆”? 🤦♂️
“产品介绍页面” 或者 “产品主页” 就好。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的哈哈哈哈哈哈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
统一一下标号方式,参考:https://github.com/FreeCodeCampChina/challenges/pull/39/files#diff-18bbc8e662f30c4c04c9f1e851e4d8f1
然后把 <code> 两边多余的的空格去掉。别的应该没啥问题了。麻烦你改下哈
| "<strong>需求 #10:</strong><code>#email</code> 输入框应该用 HTML5 验证来确认输入的是否为邮箱。", | ||
| "<strong>需求 #11:</strong>在表单中,有一个对应 <code>id=\"submit\"</code> 的 <code>input</code> 提交。", | ||
| "<strong>需求 #12:</strong>当我点击 <code>#submit</code> 元素,邮箱会被提交到一个静态页面(使用这个模拟 URL: <a href='https://www.freecodecamp.com/email-submit' target='_blank'>https://www.freecodecamp.com/email-submit</a>)它会确认邮箱成功的输入并且发送成功。", | ||
| "<strong>需求13:</strong>导航栏应保持在视口的顶部。", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这一行和其他的标号方式不统一。
建议使用 需求 13: 这样的标号方式(注意空格!),更符合中文的表达习惯。#13 其实是英文的习惯,读作 “number 13”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get
| @@ -1,5 +1,4 @@ | |||
| # Introduction to the JSON APIs and AJAX Challenges # | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你的这个 file 不该改的吧,下次提交之前checkout 一下。
https://github.com/FreeCodeCampChina/challenges/blob/translate/CONTRIBUTING.md#%E5%B8%B8%E8%A7%81%E9%97%AE%E9%A2%98
看第三个问题

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
呃呃,好的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git fetch upstream
git checkout upstream/translate -- the/path/to/that_file
这命令是在translate分支下执行的吗?另外那个the path to that file 是指哪个路径?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XERO75 在你现在的 branch 上执行就可以。
path to file 就是你要替换的文件路径啊。。你这里不小心改了 04-data-visualization/json-apis-and-ajax.md,那路径就是这个。
git checkout upstream/translate -- the/path/to/that_file
这个命令的意思就是,我要把本地的 the/path/to/that_file 文件替换成 upstream 上 translate 分支的 the/path/to/that_file 文件
然后执行一下 git status 你就能明白了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已经处理了,你看看
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有处理好。晚上联系我,我远程帮你弄吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的微信加你了
|
Changes addressed in #74 |

No description provided.