Skip to content

(DOC) CONTRIBUTING.md update #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wudifeixue merged 1 commit into from
Aug 3, 2018
Merged

(DOC) CONTRIBUTING.md update #57

wudifeixue merged 1 commit into from
Aug 3, 2018

Conversation

@S1ngS1ng
Copy link
Contributor

@S1ngS1ng S1ngS1ng commented Aug 3, 2018

In this PR:

  • Modify branch creation command, where based off upstream/translate is preferred
  • Remove inline-code blocks that are not rendered

@S1ngS1ng S1ngS1ng added the ready for review Use when a translation (?) PR is ready for review label Aug 3, 2018
@S1ngS1ng S1ngS1ng requested review from huluoyang and wudifeixue and removed request for huluoyang August 3, 2018 05:29
wudifeixue
wudifeixue approved these changes Aug 3, 2018
View reviewed changes
Copy link

@wudifeixue wudifeixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wudifeixue wudifeixue merged commit c691bdc into FreeCodeCampChina:translate Aug 3, 2018
SSShooter pushed a commit to SSShooter/challenges that referenced this pull request Sep 7, 2018
@S1ngS1ng @SSShooter
Modify branch creation command suggestion (FreeCodeCampChina#57)
6d5f24a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huluoyang huluoyang Awaiting requested review from huluoyang

1 more reviewer

@wudifeixue wudifeixue wudifeixue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready for review Use when a translation (?) PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@S1ngS1ng @wudifeixue