Skip to content

Conversation

@S1ngS1ng
Copy link
Contributor

@S1ngS1ng S1ngS1ng commented Aug 6, 2018

  • Style update, remove extra space around <code>, fix unmatched </code>
  • Translation enhancement
  • Fix typo

Follow up of #21
Add @Robin-zero for review

@S1ngS1ng S1ngS1ng added the ready for review Use when a translation (?) PR is ready for review label Aug 6, 2018
@S1ngS1ng
Copy link
Contributor Author

S1ngS1ng commented Aug 6, 2018

Copy link
Contributor

@Robin-zero Robin-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 390:你已经了解了
Line 443:有一种写法
Line 493:and -> 和
Line 623:“匹配大写和小写的 a 字符”更合适

@S1ngS1ng
Copy link
Contributor Author

S1ngS1ng commented Aug 6, 2018

@Robin-zero 感谢,已更新。
对于 line #623,我个人觉得原文的表达方式很有歧义。
如果是 match all the upper and lower "a" characters,那:
image
这里就不该 should not match,因为这里有 “a”。
这道题答案是 /Aa*/(至少这个能通过),那也不是“大写和小写的 a 字符”(否则就是 /[aA]+/,但这个显然也会在截图的测试中匹配到 a),确切地说应该是“大写 A 之后有不定数量的连续小写 a”

@S1ngS1ng S1ngS1ng added the need update Use when a translation (?) PR has been reviewed and needs to address comments label Aug 7, 2018
For challenge Match Characters that Occur Zero or More Times
@S1ngS1ng S1ngS1ng added :shipit: ship it Use when a translation (?) PR is ready for shipping and removed need update Use when a translation (?) PR has been reviewed and needs to address comments labels Aug 7, 2018
"<blockquote>let soccerWord = \"gooooooooal!\";<br>let gPhrase = \"gut feeling\";<br>let oPhrase = \"over the moon\";<br>let goRegex = /go*/;<br>soccerWord.match(goRegex); // Returns [\"goooooooo\"]<br>gPhrase.match(goRegex); // Returns [\"g\"]<br>oPhrase.match(goRegex); // Returns null</blockquote>",
"<hr>",
"创建一个正则表达式<code>chewieRegex</code>,使用<code>*</code>符号在<code>chewieQuote</code>中匹配<code>\"A\"</code>之后的所有<code>\"a\"</code>字符。你的正则表达式不需要标志,也不应该匹配任何其他引号。"
"创建一个正则表达式<code>chewieRegex</code>,使用<code>*</code>符号在<code>chewieQuote</code>中匹配大写字母<code>\"A\"</code>之后有不定数量且连续出现的小写<code>\"a\"</code>这个规则。你的正则表达式不需要标志,也不应该匹配任何其他引号。"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per @Robin-zero

@huluoyang
Copy link
Contributor

@S1ngS1ng @Robin-zero 关于:这里就不该 should not match,因为这里有 a。
/Aa*/它是先匹配 A,再匹配 a,所以这里的 should not match 并没有问题。
Create a regex chewieRegex that uses the * character to match all the upper and lower"a" characters in chewieQuote. Your regex does not need flags, and it should not match any of the other quotes.
创建一个变量为 chewieRegex 的正则,它用 * 号来匹配 chewieQuote 中的所有大写、小写 a。
它不需要修饰符,也不需要匹配引号。

@huluoyang huluoyang merged commit ed4af14 into FreeCodeCampChina:translate Aug 7, 2018
SSShooter pushed a commit to SSShooter/challenges that referenced this pull request Sep 7, 2018
* Regular expression style update

* Address comments

Fix typo

* Update description

For challenge Match Characters that Occur Zero or More Times

* fix 623 translation

* Update regular-expressions.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Use when a translation (?) PR is ready for review :shipit: ship it Use when a translation (?) PR is ready for shipping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants