-
Notifications
You must be signed in to change notification settings - Fork 32
Regular expression follow up #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regular expression follow up #66
Conversation
|
Consider using https://github.com/FreeCodeCampChina/challenges/pull/66/files?w=1 for review |
Robin-zero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 390:你已经了解了
Line 443:有一种写法
Line 493:and -> 和
Line 623:“匹配大写和小写的 a 字符”更合适
Fix typo
|
@Robin-zero 感谢,已更新。 |
For challenge Match Characters that Occur Zero or More Times
| "<blockquote>let soccerWord = \"gooooooooal!\";<br>let gPhrase = \"gut feeling\";<br>let oPhrase = \"over the moon\";<br>let goRegex = /go*/;<br>soccerWord.match(goRegex); // Returns [\"goooooooo\"]<br>gPhrase.match(goRegex); // Returns [\"g\"]<br>oPhrase.match(goRegex); // Returns null</blockquote>", | ||
| "<hr>", | ||
| "创建一个正则表达式<code>chewieRegex</code>,使用<code>*</code>符号在<code>chewieQuote</code>中匹配<code>\"A\"</code>之后的所有<code>\"a\"</code>字符。你的正则表达式不需要标志,也不应该匹配任何其他引号。" | ||
| "创建一个正则表达式<code>chewieRegex</code>,使用<code>*</code>符号在<code>chewieQuote</code>中匹配大写字母<code>\"A\"</code>之后有不定数量且连续出现的小写<code>\"a\"</code>这个规则。你的正则表达式不需要标志,也不应该匹配任何其他引号。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per @Robin-zero
|
@S1ngS1ng @Robin-zero 关于:这里就不该 should not match,因为这里有 a。 |
* Regular expression style update * Address comments Fix typo * Update description For challenge Match Characters that Occur Zero or More Times * fix 623 translation * Update regular-expressions.json

<code>, fix unmatched</code>Follow up of #21
Add @Robin-zero for review