Skip to content

Publish with GH actions#10

Merged
rokostik merged 1 commit into
mainfrom
publish-with-gha
Apr 25, 2024
Merged

Publish with GH actions#10
rokostik merged 1 commit into
mainfrom
publish-with-gha

Conversation

@rokostik
Copy link
Copy Markdown
Collaborator

This PR adds the ability to publish releases with GH actions.

@rokostik rokostik requested a review from gzuidhof April 15, 2024 10:58
@gzuidhof
Copy link
Copy Markdown
Contributor

I imagine we'll also have to add some secret to the repo? I'll make you an admin for this repo.

Copy link
Copy Markdown
Contributor

@gzuidhof gzuidhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rokostik
Copy link
Copy Markdown
Collaborator Author

I imagine we'll also have to add some secret to the repo? I'll make you an admin for this repo.

No, PIP actually has something called trusted publishers so I added this repo to our PIP project and it should work without any additional secrets.

@rokostik rokostik merged commit 1595bd4 into main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants