Merged
Conversation
multimokia
requested changes
Jan 21, 2023
Contributor
multimokia
left a comment
There was a problem hiding this comment.
Some things I noticed during testing
Co-authored-by: multimokia <multimokia3@gmail.com>
Co-authored-by: multimokia <multimokia3@gmail.com>
multimokia
requested changes
Jan 21, 2023
There was a problem hiding this comment.
ESLint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
multimokia
requested changes
Jan 29, 2023
Contributor
There was a problem hiding this comment.
Mirroring the issues mentioned in Discord here:
- The bug when trying to reset password and being shown an unauthorized page without having the option to change your password still occurs [UPDATE] - This is an issue on Firefox
- The link hover text while on the blue background of the login/pw reset page blends in and quickly becomes unreadable, perhaps changing our hover text to a light grey/white would be a better idea for readability?

multimokia
approved these changes
Jan 31, 2023
Contributor
multimokia
left a comment
There was a problem hiding this comment.
Can confirm this works on Chromium, requesting to open a tracking issue for the Firefox issue mentioned above so we can fix this later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User authorization and authentication
Goal of this pull request:
To create a mobile and desktop responsive UI and API for logging in a User, signing up a User, and allowing a User to reset their password.
API Changes
/loginA fully client-side rendered page that displays one of three auth options/UI's:
Login,Register,UpdatePasswordUsers will be able to navigate through these three states by the provided clickable links
/passwordresetOnce the User clicks on the password reset link from their email, they will be redirected to this route. This page will prompt the User to update their password and upon success will redirect them to the index page
Any additional remarks:
Upon registration, the User is prompted to log in. On successful login, the User is redirected to the index page. If any errors occur during this process, they will be listed in the UI. Non-logged in Users only have access to the
/loginroute. If a logged-in User attempts to visit the/loginpage, they will be redirected to the index page.Testing:
Describe how this feature should be tested
/passwordresetroute