Skip to content

FROS-3 Login registeration auth#10

Merged
Stan-l-e-y merged 32 commits intomainfrom
FROS-3-Login-registeration
Feb 1, 2023
Merged

FROS-3 Login registeration auth#10
Stan-l-e-y merged 32 commits intomainfrom
FROS-3-Login-registeration

Conversation

@Stan-l-e-y
Copy link
Member

@Stan-l-e-y Stan-l-e-y commented Jan 21, 2023

User authorization and authentication

Goal of this pull request:
To create a mobile and desktop responsive UI and API for logging in a User, signing up a User, and allowing a User to reset their password.

API Changes

/login

A fully client-side rendered page that displays one of three auth options/UI's: Login, Register, UpdatePassword
Users will be able to navigate through these three states by the provided clickable links

/passwordreset

Once the User clicks on the password reset link from their email, they will be redirected to this route. This page will prompt the User to update their password and upon success will redirect them to the index page

Any additional remarks:

Upon registration, the User is prompted to log in. On successful login, the User is redirected to the index page. If any errors occur during this process, they will be listed in the UI. Non-logged in Users only have access to the /login route. If a logged-in User attempts to visit the /login page, they will be redirected to the index page.

Testing:

Describe how this feature should be tested

  • Attempt any of the auth actions on all types of screen sizes and see if any elements are not accessible
  • Attempt all of the form submissions with correct and incorrect data to assure that proper success and error messages are displayed
  • Attempt the password reset flow, see if an email is sent to the provided email and if the link in the email will redirect you to the /passwordreset route
  • Attempt to reset your password, logout and try to login with both the old and new password to see if it errors on the former and logs you in with the latter

Copy link
Contributor

@multimokia multimokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things I noticed during testing

@multimokia multimokia added this to the WEEK 5 DEMO milestone Jan 21, 2023
Stan-l-e-y and others added 3 commits January 21, 2023 17:03
Co-authored-by: multimokia <multimokia3@gmail.com>
Co-authored-by: multimokia <multimokia3@gmail.com>
@Stan-l-e-y Stan-l-e-y removed the request for review from jjensen-ai January 22, 2023 13:14
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@Stan-l-e-y Stan-l-e-y marked this pull request as draft January 26, 2023 01:43
@Stan-l-e-y Stan-l-e-y changed the title Fros 3 login registeration FROS-3 Login registeration auth Jan 27, 2023
@Stan-l-e-y Stan-l-e-y added the enhancement New feature or request label Jan 27, 2023
@Stan-l-e-y Stan-l-e-y marked this pull request as ready for review January 28, 2023 13:17
Copy link
Contributor

@multimokia multimokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring the issues mentioned in Discord here:

  1. The bug when trying to reset password and being shown an unauthorized page without having the option to change your password still occurs [UPDATE] - This is an issue on Firefox
  2. The link hover text while on the blue background of the login/pw reset page blends in and quickly becomes unreadable, perhaps changing our hover text to a light grey/white would be a better idea for readability?
    image

Copy link
Contributor

@multimokia multimokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this works on Chromium, requesting to open a tracking issue for the Firefox issue mentioned above so we can fix this later

@Stan-l-e-y Stan-l-e-y merged commit 47c8d74 into main Feb 1, 2023
@Stan-l-e-y Stan-l-e-y deleted the FROS-3-Login-registeration branch February 2, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

3 participants