Open
Conversation
…od to handle updated arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I was playing around with the library and it felt a bit slow so I started poking to see if I could get a speed up. Seems to be running much more quickly now! From my tests it seems to work correctly, but it does touch quite a bit of code so perhaps there's some review in order or some testing we can do to make sure everything works the same before and after.
The main changes were:
Avoid copying the voxel array (maybe a 2x speed up already there)
Vectorize the voxel fill operatations with numpy (another big gain)
preallocating voxel space (this seemed to be happening way too frequently for some reason, so this helps a bit)
and tracking filled voxels (avoids frequently recalculating)