This repository was archived by the owner on Mar 21, 2024. It is now read-only.
fix: move button styles to shared scss file, fix Logout styling#1
Closed
ColinFrick wants to merge 1 commit intoFusionAuth:mainfrom
sonderformat-llc:buttons
Closed
fix: move button styles to shared scss file, fix Logout styling#1ColinFrick wants to merge 1 commit intoFusionAuth:mainfrom sonderformat-llc:buttons
ColinFrick wants to merge 1 commit intoFusionAuth:mainfrom
sonderformat-llc:buttons
Conversation
Contributor
Author
|
@lyleschemmerling Could you take a look at this? |
Collaborator
|
Looking at this it might be best if we define custom properties to allow consumers to style these how they need to https://angular.io/guide/component-styles#1-use-css-custom-properties-recommended |
Contributor
|
@ColinFrick please update based on lyle's feedback when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently every button has a separate scss file with its styling. This moves that styles into a single shared scss.
Additionally, the logout button has different styling to the other buttons. This was also fixed.