Skip to content

Core package should be bundled into Angular dist#113

Merged
JakeLo123 merged 2 commits intomainfrom
84-angular-core-package-should-be-a-bundled-dependency
Jun 6, 2024
Merged

Core package should be bundled into Angular dist#113
JakeLo123 merged 2 commits intomainfrom
84-angular-core-package-should-be-a-bundled-dependency

Conversation

@JakeLo123
Copy link
Contributor

Core package should be bundled into Angular dist

This is to handle #84. See "Solution" heading--it describes what has been implemented on this branch.

Changes

  • Add extra details to README including ones relevant to this architecture decision.
  • Add git-ignored src/sdkcore folder inside angular library.
  • Add getSDKCore.js and script to execute it within the angular build.
  • Add angular yalc-pub script
  • Remove use of absolute paths from core package.

Pre-Merge Checklist (if applicable)

  • Unit and Feature tests have been added/updated for logic changes, or there is a justifiable reason for not doing so.

@JakeLo123 JakeLo123 added documentation Improvements or additions to documentation Angular labels Jun 5, 2024
@JakeLo123 JakeLo123 self-assigned this Jun 5, 2024
@JakeLo123 JakeLo123 linked an issue Jun 5, 2024 that may be closed by this pull request
@JakeLo123 JakeLo123 force-pushed the 84-angular-core-package-should-be-a-bundled-dependency branch from 0970b4e to 33f92e1 Compare June 5, 2024 19:28
@JakeLo123 JakeLo123 merged commit 48de108 into main Jun 6, 2024
@JakeLo123 JakeLo123 deleted the 84-angular-core-package-should-be-a-bundled-dependency branch June 6, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Angular documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Angular] core package should be a bundled dependency

2 participants