ac-3: week-8: Prof can submit Marks to assignment and made site responsive#1156
ac-3: week-8: Prof can submit Marks to assignment and made site responsive#1156akshatnema merged 10 commits intoFusionIIIT:testfrom
Conversation
|
looks good to me, ready to merge @akshatnema |
| # class StudentAssignment(models.Model): | ||
| # student_id = models.ForeignKey(Student, on_delete=models.CASCADE) | ||
| # assignment_id = models.ForeignKey(CourseAssignment, on_delete=models.CASCADE) | ||
| # upload_time = models.DateTimeField(auto_now=True) | ||
| # # upload_url = models.TextField(max_length=200) | ||
| # doc = models.FileField(upload_to=assignment_submit_name, null=True, blank=True) | ||
| # score = models.IntegerField(null=True) #score is submitted by faculty | ||
| # feedback = models.CharField(max_length=100, null=True) #feedback by the faculty for the solution of the assignment submitted | ||
| # assign_name = models.CharField(max_length=100) | ||
|
|
||
| # def __str__(self): | ||
| # return '{} - {} - {} - {} - {}'.format( | ||
| # self.pk, self.student_id, | ||
| # self.assignment_id, self.score, | ||
| # self.feedback) |
There was a problem hiding this comment.
Kindly remove the comment which is not needed.
There was a problem hiding this comment.
Will remove it after i am sure that any other module isn't using it
|
@PranshuNayak @samay-rgb Kindly review this PR |
PranshuNayak
left a comment
PranshuNayak
left a comment
There was a problem hiding this comment.
Please push the migrations for the proposed schema changes.
tech-akash
force-pushed
the
AC-3-Week-08
branch
from
d46da63 to
6d5c360
Compare
|
@PranshuNayak @samay-rgb waiting for your review. @tech-akash Kindly resolve the merge conflicts. |
@tech-akash kindly push the remaining migrations too as discussed yesterday. |
| description = models.CharField(max_length=100) | ||
| document_name = models.CharField(max_length=40) | ||
| document_url = models.CharField(max_length=500, null=True,blank=True) | ||
| document_url = models.CharField(max_length=100, null=True,blank=True) |
There was a problem hiding this comment.
use URLField instead of charfield for document_url . For charfields use max_length=255
| course_id = models.ForeignKey(Course, on_delete=models.CASCADE) | ||
| upload_time = models.DateTimeField(auto_now=True) | ||
| document_name = models.CharField(max_length=40) | ||
| description = models.CharField(max_length=100) |
There was a problem hiding this comment.
For charfields use max_length=255
akshatnema
changed the title
|
@akshatnema Kindly revert the merged changes of this PR as it wasn't approved yet. |
5 participants
Issue that this pull request solves
Closes: # (issue number)
Proposed changes
Brief description of what is fixed or changed
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request