Github Actions : Added Mypy and Python Bandit Security automation#1284
Open
hardiksharma11 wants to merge 12 commits intoFusionIIIT:mainfrom
Open
Github Actions : Added Mypy and Python Bandit Security automation#1284hardiksharma11 wants to merge 12 commits intoFusionIIIT:mainfrom
hardiksharma11 wants to merge 12 commits intoFusionIIIT:mainfrom
Conversation
Added Bandit security test for python
Mypy is an incredibly useful tool for checking python code quality. It is more specifically a static type checker.
Apply only on changed files
Collaborator
|
Congratulations for making your first Pull Request at Fusion!! 🎉 Someone from our team will review it soon. |
Shivkant-Chauhan
suggested changes
Jan 16, 2024
Shivkant-Chauhan
left a comment
Shivkant-Chauhan
left a comment
There was a problem hiding this comment.
Thanks for the PR @hardiksharma11. I have left few changes. Also remove the irrelevant comments since not required
| uses: ioggstream/bandit-report-artifacts@v0.0.2 # Using Bandit for security checks | ||
| with: | ||
| project_path: . # Path to the project to scan | ||
| ignore_failure: true # Continue the workflow even if Bandit reports issues |
There was a problem hiding this comment.
we obviously dont want to ignore errors and failures. we want the checks to fail on encountering such errors
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest # Executes the job on the latest version of Ubuntu |
There was a problem hiding this comment.
point to a ubuntu version (preferably 22.04), not pinning a version might introduce regression in future
| @@ -0,0 +1,27 @@ | |||
| name: Security check - Bandit # Name of the GitHub Actions workflow | |||
|
|
|||
| on: [push, pull_request] # Trigger the workflow | |||
There was a problem hiding this comment.
why are you thinking we should run the actions on both the time we "push" changes and open "pull requests".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Brief description of what is fixed or changed
Mypy Check : Validate and enforce type annotations and static typing.
Bandit Security Test : Scan for security vulnerabilities and potential security risks.
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request