GAD-4: Fix edit draft functionality and usertype Access #1410
Merged
prajjwalkapoor merged 85 commits intoFusionIIIT:gad-4from Apr 11, 2024
Merged
GAD-4: Fix edit draft functionality and usertype Access #1410prajjwalkapoor merged 85 commits intoFusionIIIT:gad-4from
prajjwalkapoor merged 85 commits intoFusionIIIT:gad-4from
Conversation
Co-authored-by: A Anunaya <76819712+Anunaya07@users.noreply.github.com> Co-authored-by: Aksh Bansal <63552235+Aksh-Bansal-dev@users.noreply.github.com>
… serializers and minor bug fixes
add api for android
Author
|
@prajjwalkapoor Please take a look, thanks |
|
@Aragorn-64 Can you add a screen cast of the feature or the change made in the PR? Thanks |
|
@Bhavik-ag @Priyansh61 Here is the link for the screen cast Video Link The testing of GAD-4 identified some issues which were caused by update in the dashboard:
|
arminpatel
approved these changes
Apr 11, 2024
|
@prajjwalkapoor pls merge this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
Closes: # (issue number)
Proposed changes
Brief description of what is fixed or changed
Edit drafts now uses Dropdown designation,
Forward file now uses Dropdown designation,
Error on "Faculty" or "Staff" dropdown opening /filetracking now gives meaningful message
Save as draft now saves the remarks added
Types of changes
Bug fixes and 1 addition of invalid_designation decorator
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request