SA-1 : Hostel Management (Fixed Bugs)#1422
Merged
prajjwalkapoor merged 178 commits intoFusionIIIT:sa-1from Apr 11, 2024
Merged
Conversation
Co-authored-by: A Anunaya <76819712+Anunaya07@users.noreply.github.com> Co-authored-by: Aksh Bansal <63552235+Aksh-Bansal-dev@users.noreply.github.com>
Functionality of Hostel Allotment Backend
Functionality assigned batch
changes in student details
Student Fine Edit by Caretaker
Merging hmweb-main into hmweb-test (Changes of Anni)
student details,room allottment functionality change
Merging hmweb-main into hmweb-test
Author
|
Video Link (Open with college id only) |
@anujpatel03 can you provide a brief description of what were the issues and what are the fixes implemented? Thanks. |
Author
In all the forms phone number checks were having issue of length and type , now it has been resolved. |
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
Closes: # (issue number)
Proposed changes
Brief description of what is fixed or changed
In all the forms phone number checks were having issue of length and type , now it has been resolved.
Added room type in guest room booking ,added edit fine , added edit and remove student information.
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request
@varun7singh @ChaudharyRaman @prajjwalkapoor Kindly Merge this PR , This is updated one.
If there is any conflict then let me know.