Merged
Conversation
Co-authored-by: A Anunaya <76819712+Anunaya07@users.noreply.github.com> Co-authored-by: Aksh Bansal <63552235+Aksh-Bansal-dev@users.noreply.github.com>
|
@Srivatsa19 please fill the format of the PR, add relevant information and add screenshots + usage video |
|
Filetracking part seems to work properly, and PR format is followed. Looks good |
|
I think its ready to merge @prajjwalkapoor |
|
LGTM, merging. |
Contributor
|
FusionIIIT/applications/globals/api/views.py, I talked with the dashboard team, and this change is not supposed to be here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
Added functionality where only logged in users can access the module. The module has been implemented according to the use case diagram
Closes: # (issue number)
Proposed changes
Brief description of what is fixed or changed
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
https://drive.google.com/drive/folders/1iQBxUOuhojei7qLjph9K1bhximrseokW?usp=sharing
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request
The designations used in the module are :-
designations_list = ["Junior Engineer", "Executive Engineer (Civil)", "Electrical_AE", "Electrical_JE", "EE", "Civil_AE", "Civil_JE", "Dean (P&D)", "Director", "Accounts Admin", "Admin IWD", "Auditor"]
ajay --> Junior Engineer
dvijay --> Executive Engineer (Civil)
de --> Dean (P&D)
dir --> Director
richard --> Accounts Admin
iwdAdmin --> Admin IWD
kunal --> Auditor
@varun7singh
@ChaudharyRaman
@prajjwalkapoor