Skip to content

Comments

Merging AC-final( AC-1,AC-2, AC-3,AC-7) into latest_staging #1489

Merged
prabhatsuman merged 124 commits intolatest_stagingfrom
ac-final
Apr 22, 2024
Merged

Merging AC-final( AC-1,AC-2, AC-3,AC-7) into latest_staging #1489
prabhatsuman merged 124 commits intolatest_stagingfrom
ac-final

Conversation

@prabhatsuman
Copy link

@prabhatsuman prabhatsuman commented Apr 18, 2024


Issue that this pull request solves

Closes: # (issue number)

Proposed changes

The changes made in this pull request ensure that AC-1, AC-2, AC-3 and AC-7 are working properly.

Types of changes

Put an x in the boxes that apply:

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to break)
  • Other (please describe):

Based on the information provided, it sounds like these changes may be a bug fix or other (testing and maintenance). Choose the appropriate type of change for your pull request.

Checklist

Put an x in the boxes that apply:

  • My code follows the style guidelines of this project.

  • I have performed a self-review of my own code.

  • I have created a new branch for this pull request.

  • I have commented my code, particularly in hard-to-understand areas.

  • I have made corresponding changes to the documentation.

  • My changes generate no new warnings.

  • My changes do not break the current system and pass all the current test cases.

  • Add a checkmark for the items you have completed.

Screenshots

If applicable, please attach screenshots of the changes made, particularly for changes affecting the user interface.

Other information

The code was tested by merging the AC-final branch into the latest_staging branch of my forked repository. This testing process has confirmed that AC-1, AC-2, AC-3 and AC-7 are working properly.

If there is any other important information related to the pull request, such as known issues or further testing notes, you can include that here.


Remember to include the appropriate issue number in the "Closes" line and mark the appropriate types of changes and checklist items. Let me know if you have any more points to add or any other specific details.

Anunaya07 and others added 30 commits February 17, 2023 01:08
…tructor (#1075)

Co-authored-by: “tech-akash” <“20bcs020@iiitdmj.ac.in”>
* implemented authentication and sidenavbar

* added announcement section
* JY , 16/02/2024 6:26PM

* JY 17/02/24 11:15 AM Implemented hidden_grades

* Added apis and models

---------

Co-authored-by: Jatin Yadav <jatinyadav@Jatins-MacBook-Pro.local>
@prabhatsuman
Copy link
Author

@ChaudharyRaman @prajjwalkapoor @Priyansh61 Verify this PR.

@prabhatsuman prabhatsuman changed the title Merging AC-final( AC-1,AC-2, AC-7) into latest_staging Merging AC-final( AC-1,AC-2, AC-3,AC-7) into latest_staging Apr 21, 2024
@prabhatsuman
Copy link
Author

@ChaudharyRaman LGTM. u can proceed to merge

@prabhatsuman
Copy link
Author

@ChaudharyRaman AC-7 has used the wrong tables in their code but their Pull request cannot be reverted so we are deploying ac-final with ac-7. If they correct the code, we will merge it again to the latest staging.

@prabhatsuman prabhatsuman merged commit f97eb7b into latest_staging Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.