Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the runtime logging infrastructure to support multiple log “appenders” per Logger, and updates call sites to use the new construction pattern.
Changes:
- Refactors
runtime::logger::Loggerto store multiple appenders and introducesMultiWriterto fan out writes. - Updates contexts/tests to construct a logger via
Logger::new()and attach appenders viawith_appenderwhere needed. - Modifies
release.tomlrelease configuration (comments outallow-branch).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
crates/runtime/src/logger.rs |
Implements multi-appender logger support and a fan-out AsyncWrite (MultiWriter). |
src/context.rs |
Updates logger creation to attach a Console appender under the new API. |
crates/http-service/src/executor/http.rs |
Updates test context logger construction to match the new Logger::new() API. |
release.toml |
Comments out allow-branch, changing release branch restrictions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qrdl
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates the runtime logging to support multiple log “appenders” per Logger