Skip to content

add support for victoria_log feature with deserialization tests#114

Merged
ruslanti merged 1 commit intomainfrom
fix/victoria_log_feature
Mar 4, 2026
Merged

add support for victoria_log feature with deserialization tests#114
ruslanti merged 1 commit intomainfrom
fix/victoria_log_feature

Conversation

@ruslanti
Copy link
Collaborator

@ruslanti ruslanti commented Mar 4, 2026

No description provided.

@ruslanti ruslanti requested a review from Copilot March 4, 2026 12:38
@ruslanti ruslanti added the enhancement New feature or request label Mar 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new victoria_log logging option to the runtime app configuration model and validates JSON deserialization behavior via unit tests.

Changes:

  • Extend Log enum with a Victoria variant behind the victoria_log feature flag.
  • Add unit tests covering Log deserialization defaults, invalid values, and feature-gated variants.
  • Introduce the victoria_log feature in runtime and enable it by default; bump workspace version to 0.14.1 (with corresponding lockfile updates).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
crates/runtime/src/app.rs Adds Log::Victoria behind a feature flag and adds deserialization-focused tests (including feature-gated cases).
crates/runtime/Cargo.toml Defines the new victoria_log feature and includes it in runtime’s default feature set.
Cargo.toml Bumps workspace version to 0.14.1.
Cargo.lock Updates crate versions to match the workspace version bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ruslanti ruslanti requested a review from qrdl March 4, 2026 12:55
@ruslanti ruslanti self-assigned this Mar 4, 2026
@ruslanti ruslanti merged commit a3770bc into main Mar 4, 2026
5 of 7 checks passed
@ruslanti ruslanti deleted the fix/victoria_log_feature branch March 4, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants