add support for victoria_log feature with deserialization tests#114
Merged
add support for victoria_log feature with deserialization tests#114
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new victoria_log logging option to the runtime app configuration model and validates JSON deserialization behavior via unit tests.
Changes:
- Extend
Logenum with aVictoriavariant behind thevictoria_logfeature flag. - Add unit tests covering
Logdeserialization defaults, invalid values, and feature-gated variants. - Introduce the
victoria_logfeature inruntimeand enable it by default; bump workspace version to0.14.1(with corresponding lockfile updates).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
crates/runtime/src/app.rs |
Adds Log::Victoria behind a feature flag and adds deserialization-focused tests (including feature-gated cases). |
crates/runtime/Cargo.toml |
Defines the new victoria_log feature and includes it in runtime’s default feature set. |
Cargo.toml |
Bumps workspace version to 0.14.1. |
Cargo.lock |
Updates crate versions to match the workspace version bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qrdl
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.