Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the CLI key-value store manager lookup so get_store searches for a configured store by its connection parameter (DB URL) rather than by its human-readable name, and adds regression tests to prevent the mismatch from returning the wrong error.
Changes:
- Update
CliStoreManager::get_storeto locate a store usingKvStoreOption.param. - Add unit tests covering empty store lists, unmatched params, and ensuring lookup is not performed by store name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ruslanti
force-pushed
the
fix/clistoremanagerget_store-receives-param-redis-url-but-searches-by-storename
branch
from
5cb783d to
955bc16
Compare
qrdl
requested changes
Mar 10, 2026
Collaborator
qrdl
left a comment
qrdl
left a comment
There was a problem hiding this comment.
Since this fix is closing the issue please mention it in PR using close #<issueID>
qrdl
approved these changes
Mar 10, 2026
ruslanti
deleted the
fix/clistoremanagerget_store-receives-param-redis-url-but-searches-by-storename
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close the issue #115