Skip to content

changing kv interface#90

Merged
ruslanti merged 7 commits intomainfrom
feat/kv-support
Sep 18, 2025
Merged

changing kv interface#90
ruslanti merged 7 commits intomainfrom
feat/kv-support

Conversation

@ruslanti
Copy link
Collaborator

No description provided.

@ruslanti ruslanti requested a review from Copilot September 17, 2025 09:07
@ruslanti ruslanti self-assigned this Sep 17, 2025
@ruslanti ruslanti added the enhancement New feature or request label Sep 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements Redis support for the key-value store interface, replacing the previous dummy implementation with actual Redis connectivity. The changes upgrade the Wasmtime runtime from version 31.0.0 to 36.0.0 and add Redis as a configurable backend for key-value operations.

  • Adds Redis store implementation with support for basic operations (get, scan, zrange, zscan, cf_exists)
  • Updates the CLI to accept key-value store configuration via command line arguments and environment variables
  • Upgrades Wasmtime dependencies to version 36.0.0 with corresponding API changes

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/main.rs Adds CLI argument parsing for Redis key-value store configuration
src/key_value.rs Replaces dummy implementation with Redis-backed store manager
src/dotenv.rs Adds environment variable support for key-value store configuration
src/context.rs Updates context creation to pass store configuration to manager
crates/key-value-store/src/redis_impl.rs New Redis store implementation with async operations
crates/key-value-store/src/lib.rs Updates store interface and adds new Redis-specific methods
crates/runtime/src/lib.rs Updates for Wasmtime 36.0.0 API compatibility
crates/http-service/src/lib.rs Updates linker configuration for new Wasmtime version
Comments suppressed due to low confidence (1)

crates/http-backend/Cargo.toml:1

  • The smol_str dependency was removed but may still be used in the code. This could cause compilation errors.
[package]

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ruslanti ruslanti requested a review from qrdl September 17, 2025 12:16
@ruslanti ruslanti marked this pull request as ready for review September 17, 2025 12:17
@ruslanti ruslanti requested a review from godronus September 17, 2025 13:35
@ruslanti ruslanti merged commit 4cb5332 into main Sep 18, 2025
1 check passed
@ruslanti ruslanti deleted the feat/kv-support branch September 18, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants