Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements Redis support for the key-value store interface, replacing the previous dummy implementation with actual Redis connectivity. The changes upgrade the Wasmtime runtime from version 31.0.0 to 36.0.0 and add Redis as a configurable backend for key-value operations.
- Adds Redis store implementation with support for basic operations (get, scan, zrange, zscan, cf_exists)
- Updates the CLI to accept key-value store configuration via command line arguments and environment variables
- Upgrades Wasmtime dependencies to version 36.0.0 with corresponding API changes
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.rs | Adds CLI argument parsing for Redis key-value store configuration |
| src/key_value.rs | Replaces dummy implementation with Redis-backed store manager |
| src/dotenv.rs | Adds environment variable support for key-value store configuration |
| src/context.rs | Updates context creation to pass store configuration to manager |
| crates/key-value-store/src/redis_impl.rs | New Redis store implementation with async operations |
| crates/key-value-store/src/lib.rs | Updates store interface and adds new Redis-specific methods |
| crates/runtime/src/lib.rs | Updates for Wasmtime 36.0.0 API compatibility |
| crates/http-service/src/lib.rs | Updates linker configuration for new Wasmtime version |
Comments suppressed due to low confidence (1)
crates/http-backend/Cargo.toml:1
- The
smol_strdependency was removed but may still be used in the code. This could cause compilation errors.
[package]
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8ad8241 to
8aba29b
Compare
4ec8b8f to
bbcf003
Compare
qrdl
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.