proxy-wasm dictionary interface and sdk v0.3.0#95
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the proxy-wasm dictionary interface and upgrades the SDK to version 0.3.0. The changes refactor how dictionary instances are managed by moving the dictionary from being passed as a parameter to executor constructors to being stored in the StoreBuilder and accessed through the runtime Data struct.
- Refactored dictionary handling from constructor parameters to StoreBuilder integration
- Updated SDK submodule to commit 67ae2a07
- Cleaned up executor constructors by removing dictionary parameters
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/context.rs | Updated to use dictionary through StoreBuilder instead of passing as parameter |
| sdk | Updated submodule to new commit for v0.3.0 |
| crates/runtime/src/store.rs | Added dictionary field and builder method to StoreBuilder |
| crates/runtime/src/lib.rs | Added dictionary field to Data struct |
| crates/runtime/Cargo.toml | Added dictionary crate dependency |
| crates/http-service/src/state.rs | Removed dictionary field from HttpState |
| crates/http-service/src/lib.rs | Updated dictionary access to use runtime Data |
| crates/http-service/src/executor/wasi_http.rs | Removed dictionary parameter from constructor |
| crates/http-service/src/executor/http.rs | Removed dictionary parameter from constructor and updated test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| } | ||
|
|
||
| /// Set key value dictionary |
There was a problem hiding this comment.
The comment 'Set key value dictionary' is misleading. This method sets a dictionary, not specifically a key-value dictionary. Consider changing to 'Set dictionary' to be more accurate.
| /// Set key value dictionary | |
| /// Set dictionary |
No description provided.