Skip to content

default no value for kv store param#97

Merged
ruslanti merged 1 commit intomainfrom
no_task_default_kv_store_param
Oct 27, 2025
Merged

default no value for kv store param#97
ruslanti merged 1 commit intomainfrom
no_task_default_kv_store_param

Conversation

@ruslanti
Copy link
Collaborator

No description provided.

@ruslanti ruslanti requested review from Copilot and qrdl October 27, 2025 12:17
@ruslanti ruslanti self-assigned this Oct 27, 2025
@ruslanti ruslanti added the enhancement New feature or request label Oct 27, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a default value for the param field in the KvStoreOption struct to allow for optional deserialization, making it consistent with other optional fields in the struct.

  • Added #[serde(default)] attribute to the param field in KvStoreOption
  • Added comprehensive test coverage for default and custom deserialization scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ruslanti ruslanti merged commit 134af89 into main Oct 27, 2025
3 checks passed
@ruslanti ruslanti deleted the no_task_default_kv_store_param branch October 27, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants