refactor: rename zrange to zrange_by_score for clarity and update ret…#98
Merged
refactor: rename zrange to zrange_by_score for clarity and update ret…#98
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors the zrange method to zrange_by_score for better clarity and updates the return type to include scores alongside values. This change makes the API more explicit about its functionality and provides additional information in the response.
- Renamed
zrangemethod tozrange_by_scoreacross the trait and implementations - Updated return type from
Vec<Value>toVec<(Value, f64)>to include scores - Changed Redis implementation to use
zrangebyscore_withscoresinstead ofzrangebyscore
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk | Subproject commit update |
| crates/key-value-store/src/redis_impl.rs | Updated Redis implementation to use new method name and return scores |
| crates/key-value-store/src/lib.rs | Updated trait definition and all implementations with new method signature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qrdl
approved these changes
Nov 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qrdl
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…urn type