Default flag values for fastedge app logs and sort parameter sanitization#28
Merged
Default flag values for fastedge app logs and sort parameter sanitization#28
Conversation
qrdl
reviewed
Mar 19, 2024
| cmd.Flags().String("to", "now", "Reporting period end, UTC") | ||
| cmd.Flags().String("sort", "asc", "Log sort order, asc or desc") | ||
| cmd.Flags().String("edge", "", "Edge name filter") | ||
| cmd.Flags().String("client-ip", "", "Client IP filter") |
Collaborator
There was a problem hiding this comment.
Please hide this flag for now using https://pkg.go.dev/github.com/spf13/pflag#FlagSet.MarkHidden , I'm not sure we need to show it. Let's clarify first that it doesn't violate GDPR. It is easier to un-hide it later than remove
qrdl
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New help shows this content:
Flags: --client-ip string Client IP filter --edge string Edge name filter --from string Reporting period start, UTC (default "today") -h, --help help for show --sort string Log sort order, asc or desc (default "asc") --to string Reporting period end, UTC (default "now")