Local install and py2 boolean conversion fix #225
Conversation
| if string is None: | ||
| return None | ||
| if isinstance(string, unicode): | ||
| if type(string) in (unicode, str): |
There was a problem hiding this comment.
You can use isinstance() with a tuple as second argument. No need to switch to type()
There was a problem hiding this comment.
Since type(sthg) is used for nearly every comparable check in odml/dtypes.py i'd rather keep it consistent for now and change all type checks to isinstance checks in one go.
There was a problem hiding this comment.
Fair enough.
Opened issue #226 as a reminder to fix this.
| from odml.info import AUTHOR, CONTACT, CLASSIFIERS, HOMEPAGE, VERSION | ||
|
|
||
| try: | ||
| from odml.info import AUTHOR, CONTACT, CLASSIFIERS, HOMEPAGE, VERSION |
There was a problem hiding this comment.
Now that I see it, perhaps it's better to just do the except block and not try to import.
I wonder if it's possible to end up in a situation where the setup imports an exiting installation that has a different version number.
Since the parsing code is there, might as well, right?
3 participants
This tiny PR fixes
setup.pywhich prohibits local install if the dependencies are not already installed.