Refactor package info handling#233
Merged
achilleas-k merged 22 commits intoG-Node:masterfrom Feb 28, 2018
Merged
Conversation
The rdflib-jsonld dependency is currently not used in the project, therefore remove the dependency since 'python setup.py install' breaks on first install if both 'rdflib' and 'rdflib-jsonld' are in the requirements for some non-obvious reason.
Closes G-Node#224 Disallow setting a value that cannot be interpreted as boolean for a boolean DType.
achilleas-k
approved these changes
Feb 28, 2018
setup.py
Outdated
| HOMEPAGE = curr_args[1].replace('\'', '').strip() | ||
| elif curr_args[0] == "VERSION": | ||
| VERSION = curr_args[1].replace('\'', '').strip() | ||
| with open(os.path.join("odml/info.json")) as infofile: |
Member
There was a problem hiding this comment.
Typo here?
os.path.join("odml", "info.json")
or I guess you could remove the os.path.join (unless it's required for Windows)
Contributor
Author
There was a problem hiding this comment.
just sloppy, thx for the comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
info.pyis imported intosetup.pycurrently breaks any local install due to dependency issues on clean systems (which do not have dependencies already installed). Therefore the package information is moved toinfo.jsonand read in by bothinfo.pyandsetup.py.MANIFESTby removing the obsolete desktop entry and adding theinfo.jsonfile.rdflib-jsonlddependency since 'python setup.py install' breaks on firstinstall if both
rdflibandrdflib-jsonldare in the requirements for some non-obvious reason.